|
|
The following document contains the results of
Checkstyle
.
|
Files
|
Infos
|
Warnings
|
Errors
|
|
114
|
0
|
0
|
2994
|
|
Error
|
Line
|
|
Line does not match expected header line of 'Copyright 1999-2005 California Institute of Technology. ALL RIGHTS RESERVED. U.S. Government Sponsorship acknowledged. REDISTRIBUTION AND/OR MODIFICATION AND/OR USE OF THIS SOFTWARE WITHOUT PRIOR AUTHORIZATION IS STRICTLY FORBIDDEN.'.
|
1
|
|
|
Line is longer than 80 characters.
|
21
|
|
|
Line has trailing spaces.
|
41
|
|
|
Line has trailing spaces.
|
51
|
|
|
Missing a Javadoc comment.
|
58
|
|
|
Line is longer than 80 characters.
|
60
|
|
|
Missing a Javadoc comment.
|
61
|
|
|
Missing a Javadoc comment.
|
64
|
|
|
Missing a Javadoc comment.
|
67
|
|
|
Missing a Javadoc comment.
|
73
|
|
|
Missing a Javadoc comment.
|
76
|
|
|
Missing a Javadoc comment.
|
82
|
|
|
Missing a Javadoc comment.
|
85
|
|
|
'10L' is a magic number.
|
85
|
|
|
Missing a Javadoc comment.
|
91
|
|
|
Missing a Javadoc comment.
|
94
|
|
|
Name 'LOG' must match pattern '^[a-z
]
[a-zA-Z0-9
]
*$'.
|
94
|
|
|
Missing a Javadoc comment.
|
97
|
|
|
Name 'CONDITION_CACHE' must match pattern '^[a-z
]
[a-zA-Z0-9
]
*$'.
|
97
|
|
|
Missing a Javadoc comment.
|
100
|
|
|
Missing a Javadoc comment.
|
103
|
|
|
Missing a Javadoc comment.
|
105
|
|
|
Parameter wInst should be final.
|
105
|
|
|
Parameter instRep should be final.
|
106
|
|
|
Parameter wParentUrl should be final.
|
106
|
|
|
'10' is a magic number.
|
120
|
|
|
Line is longer than 80 characters.
|
124
|
|
|
'10' is a magic number.
|
125
|
|
|
Line has trailing spaces.
|
132
|
|
|
Method 'run' is not designed for extension - needs to be abstract, final or empty.
|
135
|
|
|
Method length is 208 lines (max allowed is 150).
|
135
|
|
|
Missing a Javadoc comment.
|
135
|
|
|
Line is longer than 80 characters.
|
148
|
|
|
Line is longer than 80 characters.
|
174
|
|
|
'1000' is a magic number.
|
187
|
|
|
Must have at least one statement.
|
188
|
|
|
Line has trailing spaces.
|
197
|
|
|
'{' is not preceded with whitespace.
|
199
|
|
|
Line has trailing spaces.
|
202
|
|
|
Line is longer than 80 characters.
|
216
|
|
|
Comment matches to-do format 'TODO:'.
|
218
|
|
|
Line is longer than 80 characters.
|
236
|
|
|
Line is longer than 80 characters.
|
238
|
|
|
Avoid inline conditionals.
|
241
|
|
|
Line is longer than 80 characters.
|
262
|
|
|
'1000' is a magic number.
|
267
|
|
|
Must have at least one statement.
|
268
|
|
|
Comment matches to-do format 'TODO:'.
|
272
|
|
|
Line is longer than 80 characters.
|
299
|
|
|
Line is longer than 80 characters.
|
310
|
|
|
Line is longer than 80 characters.
|
325
|
|
|
Method 'getWorkflowInstance' is not designed for extension - needs to be abstract, final or empty.
|
344
|
|
|
Missing a Javadoc comment.
|
344
|
|
|
Method 'stop' is not designed for extension - needs to be abstract, final or empty.
|
348
|
|
|
Missing a
Javadoc comment.
|
348
|
|
|
Method 'resume' is not designed for extension - needs to be abstract, final or empty.
|
366
|
|
|
Missing a Javadoc comment.
|
366
|
|
|
Method 'pause' is not designed for extension - needs to be abstract, final or empty.
|
372
|
|
|
Missing a Javadoc comment.
|
372
|
|
|
Method 'isPaused' is not designed for extension - needs to be abstract, final or empty.
|
381
|
|
|
Expression can be simplified.
|
382
|
|
|
Method 'isStopped' is not designed for extension - needs to be abstract, final or empty.
|
385
|
|
|
Missing a Javadoc comment.
|
385
|
|
|
Method 'getCurrentTaskId' is not designed for extension - needs to be abstract, final or empty.
|
392
|
|
|
Method 'setWorkflowInst' is not designed for extension - needs to be abstract, final or empty.
|
400
|
|
|
Parameter workflowInst should be final.
|
400
|
|
|
'workflowInst' hides a field.
|
400
|
|
|
Method 'getWaitforConditionSatisfy' is not designed for extension - needs to be abstract, final or empty.
|
407
|
|
|
Method 'setWaitforConditionSatisfy' is not designed for extension - needs to be abstract, final or empty.
|
415
|
|
|
Parameter waitforConditionSatisfy should be final.
|
415
|
|
|
Method 'getInstanceRepository' is not designed for extension - needs to be abstract, final or empty.
|
422
|
|
|
Method 'setInstanceRepository' is not designed for extension - needs to be abstract, final or empty.
|
430
|
|
|
Parameter instRep should be final.
|
430
|
|
|
Method 'getRClient' is not designed for extension - needs to be abstract, final or empty.
|
437
|
|
|
Method 'setRClient' is not designed for extension - needs to be abstract, final or empty.
|
445
|
|
|
Parameter client should be final.
|
445
|
|
|
Method 'getWmgrParentUrl' is not designed for extension - needs to be abstract, final or empty.
|
456
|
|
|
Method 'setWmgrParentUrl' is not designed for extension - needs to be abstract, final or empty.
|
464
|
|
|
Parameter wmgrParentUrl should be final.
|
464
|
|
|
'wmgrParentUrl' hides a fie
ld.
|
464
|
|
|
Missing a Javadoc comment.
|
468
|
|
|
Parameter task should be final.
|
468
|
|
|
Parameter dynMetadata should be final.
|
469
|
|
|
Line is longer than 80 characters.
|
478
|
|
|
Missing a Javadoc comment.
|
494
|
|
|
Parameter taskId should be final.
|
494
|
|
|
Missing a Javadoc comment.
|
506
|
|
|
Parameter conditionList should be final.
|
506
|
|
|
Parameter taskId shoul
d be final.
|
506
|
|
|
'}' should be on the same line.
|
522
|
|
|
'}' should be on the same line.
|
530
|
|
|
Missing a Javadoc comment.
|
550
|
|
|
Must have at least one statement.
|
557
|
|
|
Missing a Javadoc comment.
|
562
|
|
|
Missing a Javadoc comment.
|
571
|
|
|
Parameter instance should be final.
|
571
|
|
|
Parameter met should be final.
|
572
|
|
|
Parameter cfg should be final.
|
572
|
|
|
Parameter taskName should be final.
|
572
|
|
|
Missing a Javadoc comment.
|
583
|
|
|
Parameter jobId should be final.
|
583
|
|
Error
|
Line
|
|
|
Line does not match expected header line of 'Copyright 1999-2005 California Institute of Technology. ALL RIGHTS RESERVED. U.S. Government Sponsorship acknowledged. REDISTRIBUTION AND/OR MODIFICATION AND/OR USE OF THIS SOFTWARE WITHOUT PRIOR AUTHORIZATION IS STRICTLY FORBIDDEN.'.
|
1
|
|
|
Line is longer than 80 characters.
|
16
|
|
|
Redundant import from the same package - gov.nasa.jpl.oodt.cas.workflow.engine.IterativeWorkflowProcessorThread.
|
17
|
|
|
Line has trailing spaces.
|
38
|
|
|
Line is longer than 80 characters.
|
46
|
|
|
Missing a Javadoc comment.
|
49
|
|
|
Missing a Javadoc comment.
|
52
|
|
|
Missing a Javadoc comment.
|
55
|
|
|
Missing a Javadoc comment.
|
59
|
|
|
Missing a Javadoc comment.
|
62
|
|
|
Missing a Javadoc comment.
|
65
|
|
|
Line has trailing spaces.
|
69
|
|
|
Parameter instRep should be final.
|
91
|
|
|
'instRep' hides a field.
|
91
|
|
|
Parameter queueSize should be final.
|
92
|
|
|
Parameter maxPoolSize should be final.
|
92
|
|
|
Parameter minPoolSize should be final.
|
92
|
|
|
Parameter threadKeepAliveTime should be final.
|
93
|
|
|
Parameter unlimitedQueue should be final.
|
93
|
|
|
Parameter resUrl should be final.
|
93
|
|
|
'1000' is a magic number.
|
105
|
|
|
'60' is a magic number.
|
105
|
|
|
'if' construct must use '{}'s.
|
109
|
|
|
Line has trailing spaces.
|
115
|
|
|
Line is longer than 80 characters.
|
116
|
|
|
Method 'pauseWorkflowInstance' is not designed for extension - needs to be abstract, final or empty.
|
118
|
|
|
Missing a Javadoc comment.
|
118
|
|
|
Parameter workflowInstId should be final.
|
118
|
|
|
Line is longer than 80 characters.
|
120
|
|
|
Line is longer than 80 characters.
|
126
|
|
|
Line is longer than 80 characters.
|
128
|
|
|
Line has trailing spaces.
|
139
|
|
| |
